Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue#624 welcome tutorial #404

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Issue#624 welcome tutorial #404

wants to merge 19 commits into from

Conversation

fridaklockmann
Copy link
Contributor

@fridaklockmann fridaklockmann commented Jul 22, 2019 •
edited by vikre
Loading

kievu
kievu reviewed Jul 23, 2019
View reviewed changes
packages/gdl-frontend/components/WelcomeTutorial/WelcomeTutorial.js
constructor(props: Props) {
super(props);
this.state = {
open: this.props.shouldOpen,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Det er ikke nødvendig å duplisere en state når den er allerede tilgjengelig som en prop =)

vikre
vikre suggested changes Jul 29, 2019
View reviewed changes
Copy link
Contributor

@vikre vikre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

En liten kommentar som burde/må gjøres alle steder hvor du bruker tekststrenger som kunne vært på forskjellige språk :)

packages/gdl-frontend/components/WelcomeTutorial/WelcomeTutorial.js Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kievu kievu kievu left review comments

@vikre vikre vikre requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fridaklockmann @vikre @kievu @camilve