Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTOR] taleDetail 컴포넌트 리팩토링 #60

Merged
merged 3 commits into from
Aug 27, 2024
Merged

Conversation

cjy3458
Copy link
Contributor

@cjy3458 cjy3458 commented Aug 27, 2024

👀 관련 이슈

✨ 작업한 내용

  • taleDetail 컴포넌트 mood, character, contents 3가지 섹션으로 분리
  • hook을 이용한 중복 코드 제거
  • fix: 모달창 출력 조건 변경
  • fix: overflow: scroll 태그로 인한 전체 페이지 스크롤 출력 제거

🌀 PR Point

  • 학습하기 페이지에도 페이지를 벗어날 때 모달창을 출력하는 것이 아닌, 뒤로가기를 누를 때만 출력하도록 변경
  • taleDetail 3가지 hook으로 분리

@cjy3458 cjy3458 added FEAT 기능 구현 FIX 에러 해결 REFACTOR 리팩토링 labels Aug 27, 2024
@cjy3458 cjy3458 self-assigned this Aug 27, 2024
Copy link

netlify bot commented Aug 27, 2024

Deploy Preview for glowtales ready!

Name Link
🔨 Latest commit fbc3e84
🔍 Latest deploy log https://app.netlify.com/sites/glowtales/deploys/66ce16a983d3e70008ccb411
😎 Deploy Preview https://deploy-preview-60--glowtales.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cjy3458 cjy3458 merged commit 36f1c1b into develop Aug 27, 2024
7 checks passed
@gominzip gominzip deleted the refactor/#59 branch August 27, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FEAT 기능 구현 FIX 에러 해결 REFACTOR 리팩토링
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REFACTOR] TaleDetail 컴포넌트 hook 분리
1 participant