fix: race conditions + support for multiple apps/previews

[venkatamutyala]

User description

fix: race conditions
fix: support for multiple apps
remove: preview QR code sectiona nd consolidate it with the deployment preview links

---

PR Type

Bug fix, Enhancement

---

Description

• Fixed race conditions by removing unnecessary sleep and improving app status checks.
• Enhanced support for multiple applications by consolidating preview QR code generation with deployment preview links.
• Introduced a new function get_all_urls to handle multiple external URLs and generate QR codes.
• Improved logging and error handling for updating PR comments.

---

Changes walkthrough 📝

	Relevant files
Enhancement	main.py Fix race conditions and enhance app processing logic          main.py Removed unnecessary sleep to prevent race conditions. Enhanced logic to check app status before processing URLs. Consolidated preview QR code generation with deployment preview links. Introduced get_all_urls function for handling multiple URLs. +64/-50

---

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

[codiumai-pr-agent-free]

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Key issues to review Improved Error Handling The error handling in the update_pr function could be improved. Currently, it's catching all exceptions without specifying the type, which might mask unexpected errors. Code Duplication There's some code duplication in the nested if statements for checking app status and health. This could potentially be refactored into a separate function for better readability and maintainability.

[codiumai-pr-agent-free]

PR Code Suggestions ✨

Category	Suggestion	Score
Error handling	Improve exception handling by catching specific exceptions and providing more detailed error logging The exception handling block is too broad and may catch unexpected exceptions. Consider catching specific exceptions and providing more detailed error logging. main.py [129-145] try: r = update_pr( git_provider, git_commit_metadata, pr_comment, git_provider_api_token ) r.raise_for_status() commits_processed.append( app['metadata']['annotations']['head_sha'] ) logger.debug(f'updated pr comment: {r.json()}') logger.info(f'SUCCESS. Just processed PR comment for: {app["metadata"]["name"]}') -except: - logger.exception(f'Failed to process pr comment: {r.json()}') +except requests.RequestException as e: + logger.exception(f'Failed to process pr comment: {str(e)}') +except Exception as e: + logger.exception(f'Unexpected error while processing pr comment: {str(e)}') Apply this suggestion Suggestion importance[1-10]: 8 Why: This suggestion enhances error handling by catching specific exceptions, which improves the robustness of the code and provides more informative logging, making it a significant improvement.	8
Enhancement	Simplify the function by using a list comprehension and string joining The get_all_urls function could be simplified by using a list comprehension and joining the results, which would make the code more concise and Pythonic. main.py [203-212] def get_all_urls(external_urls): qr_code_url = f'https://qr-code-generator.{get_captain_domain()}/v1/qr?url=' - deployment_previews = '' - for url in external_urls: - deployment_previews += f'<details><summary>{url}</summary><br><img src="{qr_code_url}{url}" width="100" height="100"></details>' + deployment_previews = ''.join( + f'<details><summary>{url}</summary><br><img src="{qr_code_url}{url}" width="100" height="100"></details>' + for url in external_urls + ) - if deployment_previews == '': - deployment_previews = "Not available. No Ingress was configured." - - return deployment_previews + return deployment_previews or "Not available. No Ingress was configured." Apply this suggestion Suggestion importance[1-10]: 7 Why: The suggestion makes the code more concise and Pythonic, improving readability and maintainability, though it is not a critical change.	7
Best practice	Use a more descriptive variable name for the response object Consider using a more descriptive variable name instead of r for the response object from the update_pr function. This will improve code readability and maintainability. main.py [130-143] -r = update_pr( +response = update_pr( git_provider, git_commit_metadata, pr_comment, git_provider_api_token ) -r.raise_for_status() +response.raise_for_status() commits_processed.append( app['metadata']['annotations']['head_sha'] ) -logger.debug(f'updated pr comment: {r.json()}') +logger.debug(f'updated pr comment: {response.json()}') logger.info(f'SUCCESS. Just processed PR comment for: {app["metadata"]["name"]}') Apply this suggestion Suggestion importance[1-10]: 6 Why: The suggestion improves code readability by using a more descriptive variable name, which is a good practice, but it is not crucial for functionality.	6