Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

알림 저장 시 잘못된 requestId가 저장되는 문제 해결 #84

Merged
merged 2 commits into from
Mar 16, 2024

Conversation

JJ503
Copy link
Member

@JJ503 JJ503 commented Mar 9, 2024

알림 별 저장하는 requestId 설정을 수정해 주었습니다.
각 알림 별 requestId는 다음과 같습니다.

  • 친구 신청 → 친구 신청 요청자 아이디
  • 친구 신청 수락 → x
  • 골 팀 요청 → 골 아이디
  • 콕 찌르기 → x

@JJ503 JJ503 added the bug 문제 상황 수정 label Mar 9, 2024
@JJ503 JJ503 requested a review from jhsseonn March 9, 2024 12:31
@JJ503 JJ503 self-assigned this Mar 9, 2024
Copy link
Member

@jhsseonn jhsseonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정하신 부분 모두 확인했습니다!
와일드카드 관련해 수정할 부분이 있어서 rc로 남겨두겠습니다.

@@ -13,7 +13,7 @@
import com.backend.blooming.user.application.exception.NotFoundUserException;
import com.backend.blooming.user.domain.User;
import com.backend.blooming.user.infrastructure.repository.UserRepository;
import org.assertj.core.api.SoftAssertions;
import org.assertj.core.api.*;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*이 보이네요!

@@ -9,7 +9,7 @@
import com.backend.blooming.user.application.exception.NotFoundUserException;
import com.backend.blooming.user.domain.User;
import com.backend.blooming.user.infrastructure.repository.UserRepository;
import org.assertj.core.api.SoftAssertions;
import org.assertj.core.api.*;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*이 보이네요!

@@ -8,7 +8,7 @@
import com.backend.blooming.user.application.exception.NotFoundUserException;
import com.backend.blooming.user.domain.User;
import com.backend.blooming.user.infrastructure.repository.UserRepository;
import org.assertj.core.api.SoftAssertions;
import org.assertj.core.api.*;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*이 보이네요!

Copy link

Copy link
Member

@jhsseonn jhsseonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정사항 모두 확인했습니다! approve 하겠습니다.

@JJ503 JJ503 merged commit 87dcfd9 into develop Mar 16, 2024
2 checks passed
@JJ503 JJ503 deleted the fix/80 branch March 16, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 문제 상황 수정
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Bug] 알림 저장 시 잘못된 requestId가 저장되는 문제 해결
2 participants