Remove unnecessary tracker tracking #159
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These variables are unused for anything except clearing them later, and prevent switching between controller sets at runtime, like when switching from controllers to hand tracking and back.
When detaching a tracker which has become inactive, verify that it still owns its name in the XRServer. If a newer tracker has replaced it, for example when switching between controllers and hand tracking, attempting to remove it will accidentally remove the newer one instead. This should be fixed upstream, but for now this workaround avoids the problem and will be forward compatible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was testing with Quest via Steam Link and discovered that switching between controllers and hand tracking results in never having controllers again. After going around and around with this code, I found that it doesn't really need to exist at all, we just track the hands in variables so we can clear the variables later. This must be a leftover from when input 2.0 support was added.
I also discovered an issue in XRServer itself that I left a comment about, I will try to get that fixed up upstream as soon as I can.