-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tooltips on copilot #28
Conversation
Hmm, can't we just do the tooltip on the In server code too then, we can pass the tooltip with |
We can, but it will require an extra layer in terms of a wrapper element to get the styling right. Shouldn't be a big performance hit since modern browsers are fast, but it is less readable. It is also a bit weird since we use the markdown component for the tooltip. Should I still move it to the markdown component? We can't keep it in server code local to |
Position absolute does not work with display: contents, so I had to use the flexbox method |
31aaf2d
to
f54027c
Compare
0d0647d
to
8bc9c88
Compare
@devxpy PR is Updated with new changes |
style={{ height: "16px", ...props.iconStyle }} | ||
></i> | ||
<span className="tooltip_text"> | ||
<RenderedMarkdown body={props.text} className="" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This dependency loop is a bit confusing, can you refactor to have 3 widgets perhaps, RenderedMarkdownRaw (w/o tooltip), RenderedMarkdown and GooeyTooltip ?
we need a popover to implement the new workspace switcher and hence considering to ditch this and implement both popover and tooltip using https://github.com/floating-ui/floating-ui |
Task: https://app.asana.com/0/1203067047205953/1206050253347928
Server PR: GooeyAI/gooey-server#348