Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Usage dashboard timezone error #200

Merged
merged 4 commits into from
Nov 7, 2023
Merged

Usage dashboard timezone error #200

merged 4 commits into from
Nov 7, 2023

Conversation

clr-li
Copy link
Contributor

@clr-li clr-li commented Nov 5, 2023 •
edited
Loading

Asana: https://app.asana.com/0/1203067047205953/1205829859130792

image

Q/A checklist

  • Do a code review of the changes
  • Add any new dependencies to poetry & export to requirementst.txt (poetry export -o requirements.txt)
  • Carefully think about the stuff that might break because of this change
  • The relevant pages still run when you press submit
  • If you added new settings / knobs, the values get saved if you save it on the UI
  • The API for those pages still work (API tab)
  • The public API interface doesn't change if you didn't want it to (check API tab > docs page)
  • Do your UI changes (if applicable) look acceptable on mobile?

@clr-li clr-li requested a review from devxpy November 5, 2023 18:38
@devxpy
Copy link
Member

devxpy commented Nov 6, 2023

please resolve merge conflicts

@devxpy devxpy merged commit f5e72c5 into master Nov 7, 2023
1 check passed
@devxpy devxpy deleted the UsageDashboard_timezone_error branch November 7, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devxpy devxpy Awaiting requested review from devxpy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clr-li @devxpy