Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SEO meta tags for /account/ page #263

Merged
merged 4 commits into from
Feb 27, 2024
Merged

Add SEO meta tags for /account/ page #263

merged 4 commits into from
Feb 27, 2024

Conversation

nikochiko
Copy link
Member

@nikochiko nikochiko commented Jan 25, 2024

Preview
image

Q/A checklist

  • Do a code review of the changes
  • Add any new dependencies to poetry & export to requirementst.txt (poetry export -o requirements.txt)
  • Carefully think about the stuff that might break because of this change
  • The relevant pages still run when you press submit
  • If you added new settings / knobs, the values get saved if you save it on the UI
  • The API for those pages still work (API tab)
  • The public API interface doesn't change if you didn't want it to (check API tab > docs page)
  • Do your UI changes (if applicable) look acceptable on mobile?

templates/account.html Outdated Show resolved Hide resolved
@nikochiko
Copy link
Member Author

The CI failing is because the latest stable version for black went from v23.x -> v24.x.

@devxpy devxpy merged commit 8ac0e71 into master Feb 27, 2024
1 check failed
@devxpy devxpy deleted the account-meta branch February 27, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants