Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow different analysis json format #278

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Conversation

SanderGi
Copy link
Member

Task: https://app.asana.com/0/1203067047205953/1206615948153355

Q/A checklist

  • Do a code review of the changes
  • Add any new dependencies to poetry & export to requirementst.txt (poetry export -o requirements.txt)
  • Carefully think about the stuff that might break because of this change
  • The relevant pages still run when you press submit
  • If you added new settings / knobs, the values get saved if you save it on the UI
  • The API for those pages still work (API tab)
  • The public API interface doesn't change if you didn't want it to (check API tab > docs page)
  • Do your UI changes (if applicable) look acceptable on mobile?

@SanderGi
Copy link
Member Author

Btw, the tests pass on my end, not sure if I'm running them wrong?

image

@devxpy
Copy link
Member

devxpy commented Feb 27, 2024

What fixture file are you using?

@devxpy devxpy merged commit fe4e2fc into master Feb 27, 2024
1 check failed
@devxpy devxpy deleted the copilot_stats_bug_fixes branch February 27, 2024 14:07
@SanderGi
Copy link
Member Author

What fixture file are you using?

The one sent on dara engineering by Kaustubh, I thought the tests should test on a fresh database though?

@SanderGi
Copy link
Member Author

I think we need to use distinct on this combined query to filter out duplicates 🤔 The problem fixed locally but not for zephyr:
image

@SanderGi
Copy link
Member Author

SanderGi commented Feb 27, 2024

I think we need to use distinct on this combined query to filter out duplicates 🤔 The problem fixed locally but not for zephyr: image

Actually, this has to do with the daily averages thing for greater date ranges, will push a fix.

Also didn't fix for Opportunity, they likely have a third format: https://gooey.ai/stats/?bi_id=22&view=Daily&details=Conversations&start_date=2024-02-01&end_date=2024-02-21&sort_by=Messages

@devxpy
Copy link
Member

devxpy commented Feb 27, 2024

What fixture file are you using?

The one sent on dara engineering by Kaustubh, I thought the tests should test on a fresh database though?

Try https://storage.googleapis.com/dara-c1b52.appspot.com/daras_ai/media/7b184698-d590-11ee-bdba-8e93953183bb/fixture.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants