Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login set title and description #280

Merged
merged 4 commits into from
Feb 27, 2024
Merged

Conversation

clr-li
Copy link
Contributor

@clr-li clr-li commented Feb 19, 2024

Asana: https://app.asana.com/0/1203067047205953/1206625446424431

image

Q/A checklist

  • Do a code review of the changes
  • Add any new dependencies to poetry & export to requirementst.txt (poetry export -o requirements.txt)
  • Carefully think about the stuff that might break because of this change
  • The relevant pages still run when you press submit
  • If you added new settings / knobs, the values get saved if you save it on the UI
  • The API for those pages still work (API tab)
  • The public API interface doesn't change if you didn't want it to (check API tab > docs page)
  • Do your UI changes (if applicable) look acceptable on mobile?

@clr-li clr-li requested a review from devxpy February 19, 2024 18:17
@devxpy devxpy merged commit c4dfc0c into master Feb 27, 2024
1 check failed
@devxpy devxpy deleted the login-set-title-and-description branch February 29, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants