-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store Stripe billing info + auto recharge without subscription #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix payment method not being saved after addon purchase - enable setup_future_usage - Update subscription creation logic to avoid unnecessary Stripe checkout session when a default payment method exists. - Revert handle_checkout_session_completed() - don't save default payment method until invoice is paid - Simplify and consolidate default payment method save in `app_users.tasks`. - Handle Stripe subscription cancellation 404 - Fix billing logic to check for default payment method, add warning for missing method on auto-recharge - Add new utility functions in `Subscription` model to streamline default auto-recharge parameter settings - Modify admin view to include readonly fields for `created_at`, `updated_at`, and `get_payment_method_summary`. - Remove non-explicit `set_free_subscription_for_user` function. - update Subscription.is_paid to use PricingPlan.monthly_charge - Update unique constraint condition in Subscription model to check for monthly charge greater than zero instead of specific plan
- Allow the user to choose if they want to save payment information when doing one time addon purchases - Handle payment info being removed from stripe by user - Check and restore existing stripe subscriptions if database is out of sync
devxpy
force-pushed
the
autorecharge-after-oneoff
branch
from
August 23, 2024 08:24
2066ec8
to
20f0fa9
Compare
9 tasks
can you review this once please |
nikochiko
commented
Aug 23, 2024
nikochiko
commented
Aug 23, 2024
nikochiko
commented
Aug 23, 2024
nikochiko
commented
Aug 23, 2024
thanks! this looks great when I tried it out. |
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Q/A checklist
You can visualize this using tuna:
To measure import time for a specific library:
To reduce import times, import libraries that take a long time inside the functions that use them instead of at the top of the file:
Legal Boilerplate
Look, I get it. The entity doing business as “Gooey.AI” and/or “Dara.network” was incorporated in the State of Delaware in 2020 as Dara Network Inc. and is gonna need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Dara Network Inc can use, modify, copy, and redistribute my contributions, under its choice of terms.