Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twilio - Option to Give Each call a Fresh History #427

Merged
merged 3 commits into from
Aug 28, 2024

Conversation

SanderGi
Copy link
Member

@SanderGi SanderGi commented Aug 9, 2024

Task: https://app.asana.com/0/1203067047205953/1207977643971933

Q/A checklist

  • If you add new dependencies, did you update the lock file?
poetry lock --no-update
  • Run tests
ulimit -n unlimited && ./scripts/run-tests.sh
  • Do a self code review of the changes - Read the diff at least twice.
  • Carefully think about the stuff that might break because of this change - this sounds obvious but it's easy to forget to do "Go to references" on each function you're changing and see if it's used in a way you didn't expect.
  • The relevant pages still run when you press submit
  • The API for those pages still work (API tab)
  • The public API interface doesn't change if you didn't want it to (check API tab > docs page)
  • Do your UI changes (if applicable) look acceptable on mobile?
  • Ensure you have not regressed the import time unless you have a good reason to do so.
    You can visualize this using tuna:
python3 -X importtime -c 'import server' 2> out.log && tuna out.log

To measure import time for a specific library:

$ time python -c 'import pandas'

________________________________________________________
Executed in    1.15 secs    fish           external
   usr time    2.22 secs   86.00 micros    2.22 secs
   sys time    0.72 secs  613.00 micros    0.72 secs

To reduce import times, import libraries that take a long time inside the functions that use them instead of at the top of the file:

def my_function():
    import pandas as pd
    ...

Legal Boilerplate

Look, I get it. The entity doing business as “Gooey.AI” and/or “Dara.network” was incorporated in the State of Delaware in 2020 as Dara Network Inc. and is gonna need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Dara Network Inc can use, modify, copy, and redistribute my contributions, under its choice of terms.

@SanderGi
Copy link
Member Author

SanderGi commented Aug 9, 2024

@devxpy, I don't think adding id in user_id_fields is correct logic. It counts my missed calls convos as separate users and over counts slack users by also counting personal channels:
image
I believe the reason it was changed to include id in the id fields is to make the unique_user_id function work for get_display_name so I've changed it to only include id for this special case. Lmk if this has any side effects that I have missed

@SanderGi SanderGi changed the title Twilio - Option to Give Each call a Fresh History [draft] Twilio - Option to Give Each call a Fresh History Aug 9, 2024
@devxpy
Copy link
Member

devxpy commented Aug 13, 2024

@devxpy, I don't think adding id in user_id_fields is correct logic. It counts my missed calls convos as separate users and over counts slack users by also counting personal channels: image I believe the reason it was changed to include id in the id fields is to make the unique_user_id function work for get_display_name so I've changed it to only include id for this special case. Lmk if this has any side effects that I have missed

makes sense, will test and revert

@devxpy devxpy force-pushed the twilio_fresh_call_history_setting branch from 6fe0be0 to af62097 Compare August 28, 2024 12:18
- Modify Conversation model to include twilio_call_sid in indexes
- Update TwilioVoice handler to not create a conversation entry for missed calls
- Simplify logic for determining if call will be rejected
- rename TwilioVoice.from_data -> TwilioVoice.from_webhook_data
@devxpy devxpy force-pushed the twilio_fresh_call_history_setting branch from af62097 to 2cbba7c Compare August 28, 2024 12:19
@devxpy devxpy merged commit ca2270a into master Aug 28, 2024
4 of 5 checks passed
@devxpy devxpy deleted the twilio_fresh_call_history_setting branch August 28, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants