Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run before save - if unsaved changes in current run #445

Merged
merged 3 commits into from
Aug 29, 2024
Merged

Conversation

nikochiko
Copy link
Member

@nikochiko nikochiko commented Aug 27, 2024

Q/A checklist

  • If you add new dependencies, did you update the lock file?
poetry lock --no-update
  • Run tests
ulimit -n unlimited && ./scripts/run-tests.sh
  • Do a self code review of the changes - Read the diff at least twice.
  • Carefully think about the stuff that might break because of this change - this sounds obvious but it's easy to forget to do "Go to references" on each function you're changing and see if it's used in a way you didn't expect.
  • The relevant pages still run when you press submit
  • The API for those pages still work (API tab)
  • The public API interface doesn't change if you didn't want it to (check API tab > docs page)
  • Do your UI changes (if applicable) look acceptable on mobile?
  • Ensure you have not regressed the import time unless you have a good reason to do so.
    You can visualize this using tuna:
python3 -X importtime -c 'import server' 2> out.log && tuna out.log

To measure import time for a specific library:

$ time python -c 'import pandas'

________________________________________________________
Executed in    1.15 secs    fish           external
   usr time    2.22 secs   86.00 micros    2.22 secs
   sys time    0.72 secs  613.00 micros    0.72 secs

To reduce import times, import libraries that take a long time inside the functions that use them instead of at the top of the file:

def my_function():
    import pandas as pd
    ...

Legal Boilerplate

Look, I get it. The entity doing business as “Gooey.AI” and/or “Dara.network” was incorporated in the State of Delaware in 2020 as Dara Network Inc. and is gonna need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Dara Network Inc can use, modify, copy, and redistribute my contributions, under its choice of terms.


- Always fetch the run_id & uid from the current run instead of query params when subscribing to realtime channel
- Rename `_has_current_run_changed` ->  `_has_request_changed` + add caching
- Handle state reload after redirect to same url in react code
- Remove un-used parameter `redirect_to`
- Rename `submit` -> `submit_and_redirect`
- Render header after inputs so that changes can be detected
- Don't save published run if saved run creation fails, close dialog and show error instead
- Remove checks for published_run being None since we have published_run always
- Show published run save buttons immediately after making a change
- Avoid init-ing state.variables = {} un-necessarily
@devxpy devxpy merged commit 904e836 into master Aug 29, 2024
5 of 6 checks passed
@devxpy devxpy deleted the run-before-save branch August 29, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants