Update gradle and add namespaces #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlegNitz
approved these changes
Jan 14, 2025
Probably previously it was located at jcenter, but not anymore. On maven there are only latest 2.28+ versions and we want to stay on 2.19 for now.
Starting from Gradle 8.0 aidl feature is disabled by default. This commit enables aidl for play billing module.
Gradle 8.9 uses JDK 22 to run test, bumping mock libraries to stop tests failing.
Starting from AGP 8.0 R class properties are non-final. Switch-case expects properties, therefore, replacing it with plain-old .
Starting from AGP 8.0 packageName is replaced in favor of namespaces in gradle.
Play Market enforces minimum target 33 sdk, we need to migrate but with a proper plan beforehand.
Use ViewHodler.getAdapterPosition() instead of method position.
Starting from 33 SDK applications should specify runtime notification permission in the manifest
This was referenced Jan 17, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates only Gradle version and JDK for Github workflow, without updating targetSdkVersion