[Feature] set up additional config totalBuildsToKeep for deleteOldBuilds Job
#997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Another alternative is to set target projects in the cronJob that way we could create jobs per project with reduced |
|
Any thoughts on this? |
| @@ -202,7 +202,8 @@ declare global { | |||
|
|
|||
| export interface DeleteOldBuildsCron { | |||
| schedule: string; | |||
| maxAgeInDays: number; | |||
| maxAgeInDays?: number; | |||
| totalBuildsToKeep?: number; | |||
There was a problem hiding this comment.
I'd prefer maxBuildsToKeep, just to match the other field here that defines a limit.
actually, just maxBuilds should do it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
We've found over time that different Projects have more activity than others. We've seen the MAX history for a specific runURL can be as little as 3 weeks ago. Where less frequently tested projects can have a history of 3 Months within the same amount of builds shown in the graph. Due to this wide range we have 2 months worth of builds for the busier project that are unviewable in the UI.
To keep storage optimisied we think the option to be able to keep a MAX amount of builds (like 150 or whatever is available to be viewed in the UI) would be more suitable for the different project types. We don't want to limit all projects to three weeks as they may not make as many frequent changes.
Changes
totalBuildsToKeepas part ofdeleteOldBuildsCronfindRemainingBuildsmethod tostorage-methodto return builds found aftertotalBuildsToKeeptotalBuildsToKeepmaxAgeInDaysto be an optional config option. Now eithertotalBuildsToKeepormaxAgeInDayscan be used or both?