Skip to content

Commit

Permalink
misc(ci): workaround Chrome developer sandbox restrictions
Browse files Browse the repository at this point in the history
  • Loading branch information
adamraine committed Jan 6, 2025
1 parent 240102e commit 7f830c4
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 0 deletions.
3 changes: 3 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ jobs:
runs-on: ubuntu-latest
env:
CHROME_PATH: ${{ github.workspace }}/.tmp/chrome-tot/chrome
# Dev builds like ToT need this in Ubuntu 23.10+
# https://chromium.googlesource.com/chromium/src/+/main/docs/security/apparmor-userns-restrictions.md
CHROME_DEVEL_SANDBOX: ${{ github.workspace }}/.tmp/chrome-tot/chrome_sandbox
FORCE_COLOR: true

# A few steps are duplicated across all jobs. Can be done better when this feature lands:
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/devtools.yml
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,9 @@ jobs:
runs-on: ubuntu-latest
env:
CHROME_PATH: ${{ github.workspace }}/lighthouse/.tmp/chrome-tot/chrome
# Dev builds like ToT need this in Ubuntu 23.10+
# https://chromium.googlesource.com/chromium/src/+/main/docs/security/apparmor-userns-restrictions.md
CHROME_DEVEL_SANDBOX: ${{ github.workspace }}/.tmp/chrome-tot/chrome_sandbox
FORCE_COLOR: true
name: DevTools smoke ${{ matrix.smoke-test-shard }}/${{ strategy.job-total }}

Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/smoke.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ jobs:
runs-on: ubuntu-latest
env:
CHROME_PATH: ${{ github.workspace }}/.tmp/chrome-tot/chrome
# Dev builds like ToT need this in Ubuntu 23.10+
# https://chromium.googlesource.com/chromium/src/+/main/docs/security/apparmor-userns-restrictions.md
CHROME_DEVEL_SANDBOX: ${{ github.workspace }}/.tmp/chrome-tot/chrome_sandbox
# The total number of shards. Set dynamically when length of *single* matrix variable is
# computable. See https://github.community/t/get-length-of-strategy-matrix-or-get-all-matrix-options/18342
SHARD_TOTAL: 3
Expand Down Expand Up @@ -132,6 +135,9 @@ jobs:
runs-on: ubuntu-latest
env:
CHROME_PATH: ${{ github.workspace }}/.tmp/chrome-tot/chrome
# Dev builds like ToT need this in Ubuntu 23.10+
# https://chromium.googlesource.com/chromium/src/+/main/docs/security/apparmor-userns-restrictions.md
CHROME_DEVEL_SANDBOX: ${{ github.workspace }}/.tmp/chrome-tot/chrome_sandbox
# The total number of shards. Set dynamically when length of *single* matrix variable is
# computable. See https://github.community/t/get-length-of-strategy-matrix-or-get-all-matrix-options/18342
SHARD_TOTAL: 3
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/unit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ jobs:
name: node ${{ matrix.node }}
env:
CHROME_PATH: ${{ github.workspace }}/.tmp/chrome-tot/chrome
# Dev builds like ToT need this in Ubuntu 23.10+
# https://chromium.googlesource.com/chromium/src/+/main/docs/security/apparmor-userns-restrictions.md
CHROME_DEVEL_SANDBOX: ${{ github.workspace }}/.tmp/chrome-tot/chrome_sandbox
LATEST_NODE: '18'
FORCE_COLOR: true

Expand Down

0 comments on commit 7f830c4

Please sign in to comment.