core(duplicated-javascript): exclude header size for estimating wasted bytes #15667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
force-pushed
the
dup-js-transfers
branch
from
957c909 to
05afd21
Compare
connorjclark
changed the title
adamraine
reviewed
Dec 6, 2023
| // FYI: older devtools logs (like our test fixtures) seems to be lower case, while modern logs | ||
| // are Cased-Like-This. | ||
| const pattern = /^content-encoding$/i; | ||
| return record.responseHeaders.some(item => item.name.match(pattern)); |
There was a problem hiding this comment.
nit: item.name.toLowerCase() has worked in the past. Just easier to read than a regex IMO but up to you
There was a problem hiding this comment.
lots of headers / churn with temporary strings, so I wanted to avoid
adamraine
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
following up to #15640, but doing it for duplicated-javascript.
The estimated savings changed so drastically b/c the test took a shortcut involving mixing artifacts from two different sources. The old transfer estimate ratio would use
script.lengthas the content length to divide the transfer size w/ to get the ratio - but that script content was from coursehero logs, and the transfer size was from paulirish.com. The new content size estimate function will first look atnetwork.resourceSize, and only fallback toscript.lengthif the network record is missing. Hence the big shift in the test results.