Sort the classes that appear in attribution selectors to reduce cardinality #518
+15
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rviscomi
reviewed
Sep 5, 2024
philipwalton
reviewed
Sep 6, 2024
|
We really need unit tests for this... |
I was just going to add that we should have a test for this behavior. |
philipwalton
requested changes
Sep 26, 2024
There was a problem hiding this comment.
Coming back to this PR. I think there are still two things that need to be address before we can merge:
- Address the open comment to shorten/simplify the selector generation logic.
- Update the tests to include some cases where there are classes out of order that get properly ordered when the tests are run.
philipwalton
approved these changes
Sep 27, 2024
|
I decided to just add them because I wanted to look at this code for some other v5 PRs as well. |
philipwalton
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #514
Adding this to v5 branch due reasons given in #514 (comment)