Spanner query for missing one implementation feature IDs #1265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KyleJu
force-pushed
the
mis-impl-spanner
branch
from
0d17beb to
335014d
Compare
KyleJu
force-pushed
the
mis-impl-spanner
branch
from
3268648 to
9109d87
Compare
jcscottiii
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A part of #1109. Implementing the Spanner logic to retrieve the list of feature IDs that are counted as "missing one implementation" for a target browser and target date.
This change is similar to the implementation in https://github.com/GoogleChrome/webstatus.dev/blob/main/lib/gcpspanner/missing_one_implementation.go#L197, but with a simpler template. Unlike that implementation, both GCP and local emulator use the same template.
A simpler version is tested on the Spanner studio
Follow-up:
Handle potential exclusions specified in the ExcludedFeatureKeys table.
support pagination to handle potentially large numbers of feature IDs.