Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP Server: remove user saved search #1266

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

jcscottiii
Copy link
Collaborator

@jcscottiii jcscottiii commented Mar 11, 2025

This change implements the http handler for removing a user saved search.

After calling the adapter layer (which is implemented in #1264), we:

  • Check the error type to distinguish between:
    • A missing saved search
    • A saved search that the user does not have access to delete
    • A generic error

Other changes:

  • Modify the test helper when comparing No content responses.

This change implements the http handler for removing a user saved search.

After calling the adapter layer (which is implemented in #1264), we:
- Check the error type to distinguish between:
  - A missing saved search
  - A saved search that the user does not have access to delete
  - A generic error
@jcscottiii jcscottiii requested review from jrobbins and KyleJu March 11, 2025 17:43
@jcscottiii jcscottiii added this pull request to the merge queue Mar 11, 2025
Merged via the queue into main with commit a32dce6 Mar 11, 2025
6 checks passed
@jcscottiii jcscottiii deleted the jcscottiii/server-delete-saved-search branch March 11, 2025 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants