feat: do not emit initial navigation events #2796
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadym-chromium
added
DO NOT MERGE
OrKoN
reviewed
Nov 21, 2024
| @@ -55,6 +55,8 @@ export class BrowsingContextImpl { | |||
| * If null, this is a top-level context. | |||
| */ | |||
| #parentId: BrowsingContext.BrowsingContext | null = null; | |||
| /** Flags if the initial navigation to `about:blank` is in progress. */ | |||
| #initialNavigation = true; | |||
There was a problem hiding this comment.
I think the root cause is that Target.createTarget actually starts a second navigation after creating a new browsing context?
There was a problem hiding this comment.
If the new target is created by window.open, the initial navigation is emitted as well
There was a problem hiding this comment.
I see navigate calls in the window.open steps https://html.spec.whatwg.org/#window-open-steps
There was a problem hiding this comment.
I think it might be depending on the windowType result.
There was a problem hiding this comment.
btw it looks like old headless implementation does not do a navigation (on Target.createTarget)
sadym-chromium
force-pushed
the
sadym/initial-navigation
branch
from
546056c
to
943c091
Compare
sadym-chromium
force-pushed
the
sadym/initial-navigation
branch
from
b1fd7dc
to
8c346fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #2793