-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Include individual site summaries in the aggregated report of a sitemap #849
Conversation
packages/common/src/utils/generateReports/generateRootSummaryDataCSV.ts
Outdated
Show resolved
Hide resolved
QA : The heading for "Analytics Cookies with issues, Functional cookies with issues, Marketing Cookies with issues, Uncategorized cookies with issues" are not correct in CSV. |
Correct headings.
const extractedData: { [key: string]: CookieTableData } = reshapeCookies( | ||
extractReportData(siteMapAnalysisData).landingPageCookies | ||
); | ||
const headers = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many of the heading texts have translations available.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Description
The PR aims to modify the generated CSV for a sitemap, where the count for each URL is provided along with the aggregated counts.
Testing Instructions
npm i
&&npm run build:cli
.-o
or download the zip from the CLI-dashboard.Checklist
Fixes #850