Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Include individual site summaries in the aggregated report of a sitemap #849

Merged
merged 4 commits into from
Oct 15, 2024

Conversation

amovar18
Copy link
Collaborator

@amovar18 amovar18 commented Oct 11, 2024

Description

The PR aims to modify the generated CSV for a sitemap, where the count for each URL is provided along with the aggregated counts.

Testing Instructions

  • Clone this PR.
  • In the terminal run npm i && npm run build:cli.
  • Now run analysis on a sitemap with -o or download the zip from the CLI-dashboard.

Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Fixes #850

@amovar18 amovar18 self-assigned this Oct 11, 2024
@amovar18 amovar18 linked an issue Oct 11, 2024 that may be closed by this pull request
3 tasks
@milindmore22
Copy link
Collaborator

QA : The heading for "Analytics Cookies with issues, Functional cookies with issues, Marketing Cookies with issues, Uncategorized cookies with issues" are not correct in CSV.

const extractedData: { [key: string]: CookieTableData } = reshapeCookies(
extractReportData(siteMapAnalysisData).landingPageCookies
);
const headers = [
Copy link
Collaborator

@mayan-000 mayan-000 Oct 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many of the heading texts have translations available.

@amovar18 amovar18 changed the title Fix/aggregated csv Refactor: Aggregated CSVV Oct 14, 2024
@amovar18 amovar18 changed the title Refactor: Aggregated CSVV Refactor: Aggregated CSV Oct 14, 2024
Copy link
Collaborator

@mohdsayed mohdsayed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@mohdsayed mohdsayed added this to the v0.12 milestone Oct 15, 2024
@mohdsayed mohdsayed changed the title Refactor: Aggregated CSV Feature: Include individual site summaries in the aggregated report of a sitemap Oct 15, 2024
@mohdsayed mohdsayed merged commit 9782526 into develop Oct 15, 2024
6 checks passed
@mohdsayed mohdsayed deleted the fix/aggregated-csv branch October 15, 2024 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance Aggregated Report CSV with URL Column
5 participants