Feature: Add EE for topics panel #861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…resizable component
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
@milindmore22 Lets QA this PR |
This comment was marked as resolved.
This comment was marked as resolved.
|
@mayan-000 Some more items to be done in a separate PR as we discussed.
|
mohdsayed
approved these changes
Nov 20, 2024
amovar18
pushed a commit
that referenced
this pull request
Dec 12, 2024
* Add header section with button, slider, add table tray with tabs and resizable component * Add epoch table and more tabs * Move components and reorganize * Setup ee for PA * Add PA tables to tray config * Use half pointers for slider * Use props for tab state * Move active tab state a level up * Add callbacks to retrieve vertical bar color hash * Add query state * Change colors for dark mode * Add checkboxes for PA * Change checkboxes layout * Setup topics animation * Break p5 into files and use with React * Draw info box * Update container sizes * overflow to resize * Handle play/pause and reset callbacks * Handle animation speed step * Handle user visit data change * Render data in the tables * UI changes * Render border conditionally * Update border * Animation, table UI changes * Refactor code * Update UI, handle unexpected flow by updating calls * Auto change active tab * Extend timeline * Make animation continuous with animation consitency if moved to previous tab * Refactor callback and conditionally call user visit * use ref for not rendering on animation var value change * Dont overlap with horizontal lines * Update image data * Add line from circle to infoox * Update color circles sizes and text placement * handle restart of animation on complete when replay is clicked * Update callbacks for user visit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds EE animation to the topics panel, under the Explorable Explanation tab.
Relevant Technical Choices
Testing Instructions
Additional Information:
Screenshot/Screencast
Checklist
This code is covered by unit tests to verify that it works as intended.Fixes #856