Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Introduce new explorable-explanations package and create reusable components #866

Merged
merged 37 commits into from
Nov 14, 2024

Conversation

mohdsayed
Copy link
Collaborator

@mohdsayed mohdsayed commented Nov 5, 2024

Description

This PR introduces a new package, @google-psat/explorable-explanations, which provides reusable components designed to support various auction scenarios and the joinInterestGroup flows. While this PR includes initial assembly of some components for auction-related functionality, it does not implement the complete flow. Separate PRs will address the single-seller and multi-seller flows in detail.

Relevant Technical Choices

Testing Instructions

Use npm i && npm run dev:ee:pa from root directory.

Additional Information:

Screenshot/Screencast


Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • [ ] This code is covered by unit tests to verify that it works as intended.
  • [ ] The QA of this PR is done by a member of the QA team (to be checked by QA).

Partially addresses #857

@mohdsayed mohdsayed added this to the v0.12 milestone Nov 5, 2024
@mohdsayed mohdsayed changed the title Feature: Create reusable components for EE Feature: Introduce new explorable-explanations package and create reusable components Nov 7, 2024
@mohdsayed mohdsayed self-assigned this Nov 13, 2024
@mohdsayed mohdsayed marked this pull request as ready for review November 13, 2024 15:42
Copy link
Collaborator

@amovar18 amovar18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mohdsayed mohdsayed merged commit e3c7220 into develop Nov 14, 2024
6 checks passed
@mohdsayed mohdsayed deleted the ee-pa/single-seller branch November 14, 2024 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants