-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Introduce new explorable-explanations package and create reusable components #866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohdsayed
changed the title
Feature: Create reusable components for EE
Feature: Introduce new explorable-explanations package and create reusable components
Nov 7, 2024
…l into ee-pa/single-seller
amovar18
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new package, @google-psat/explorable-explanations, which provides reusable components designed to support various auction scenarios and the joinInterestGroup flows. While this PR includes initial assembly of some components for auction-related functionality, it does not implement the complete flow. Separate PRs will address the single-seller and multi-seller flows in detail.
Relevant Technical Choices
Testing Instructions
Use
npm i && npm run dev:ee:pa
from root directory.Additional Information:
Screenshot/Screencast
Checklist
[ ] This code is covered by unit tests to verify that it works as intended.[ ] The QA of this PR is done by a member of the QA team (to be checked by QA).Partially addresses #857