Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Add topics legend tab #958

Merged
merged 5 commits into from
Feb 18, 2025
Merged

Feature: Add topics legend tab #958

merged 5 commits into from
Feb 18, 2025

Conversation

mayan-000
Copy link
Collaborator

@mayan-000 mayan-000 commented Feb 18, 2025 •
edited by mohdsayed
Loading

Description

This PR adds a legend tab to topics EE.

  • The legend tab contains general information about topics EE.

Relevant Technical Choices

Testing Instructions

  • Open PSAT and navigate to topics EE.
  • Open the Legend tab, the tab should contain basic information about topics.
  • Switch between tabs should not affect the EE, no distorted figures should be present.

Additional Information:

Screenshot/Screencast

Screen.Recording.2025-02-18.at.11.14.42.mov

Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Partially addresses #856

@mayan-000 mayan-000 marked this pull request as ready for review February 18, 2025 05:51
@mohdsayed
Copy link
Collaborator

mohdsayed commented Feb 18, 2025 •
edited
Loading

  • Later we need to think if it's important to pause the flow when the user is on the Legend tab.
  • Final QA by @milindmore22

@mohdsayed mohdsayed added this to the v0.13.0 milestone Feb 18, 2025
@mohdsayed mohdsayed merged commit e29a6c2 into develop Feb 18, 2025
6 checks passed
@mohdsayed mohdsayed deleted the feat/topics-legend-tab branch February 18, 2025 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohdsayed mohdsayed mohdsayed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.13.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mayan-000 @mohdsayed