-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prerender EAGERNERSS #436
Prerender EAGERNERSS #436
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the contribution!
@giorgiopellegrino could i ask if you can resolve the conflicts introduced after we landed #435? Happy to land this after. |
…into prerender-eagerness
…grino/quicklink into prerender-eagerness
…icklink into prerender-eagerness
…into prerender-eagerness
Hello @addyosmani , I’ve pulled the latest changes from the main branch and solved the conflicts. Thank you for merging the pull requests! Giorgio |
Thank you for resolving those merge conflicts. Very much appreciate it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @addyosmani , thank you so much for completing the pull request! |
Thank you so much once again for all of your work on the recent pull requests. I really appreciate the improvements that you've been making to the library. I will aim to get these out in a new release soon. We're just going to try cleaning up some final additions that ideally get our CI passing again, but expect them to be in a stable release soon. |
Hello @addyosmani and @XhmikosR,
I have implemented a key feature for my company that allows prerendering URLs with an eagerness configuration. The fallback is a prefetch triggered on mouseenter when the eagerness property is set to "moderate" or "conservative."
Main changes:
mouseenter
event.mouseenter
, if the eagerness mode is ‘moderate’ or ‘conservative’.options
property, and they will only be executed when elements enter the viewport: options.onlyOnMouseover, options.eagernessI hope these changes will be appreciated, as they are currently in use across our e-commerce platforms.
Thank you very much.
Giorgio Pellegrino.
cc @gilbertococchi