Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update integration test logic #1138

Merged
merged 3 commits into from
Jul 30, 2024
Merged

Conversation

jackwotherspoon
Copy link
Collaborator

@jackwotherspoon jackwotherspoon commented Jul 29, 2024

Pull request from forks once merged will still be skipped github.event.pull_request.head.repo.full_name will still be that of the fork.

To combat this we run the job on all events that are not a pull_request (aka schedule and push)

@jackwotherspoon jackwotherspoon self-assigned this Jul 29, 2024
@jackwotherspoon jackwotherspoon requested a review from a team as a code owner July 29, 2024 20:26
Copy link
Member

@enocom enocom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment explaining why we're doing this would be nice for future readers.

Also, bonus points if we can split this across multiple lines to make it more readable.

@jackwotherspoon jackwotherspoon merged commit a9b6646 into main Jul 30, 2024
15 checks passed
@jackwotherspoon jackwotherspoon deleted the jackwotherspoon-patch-1 branch July 30, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants