Skip to content
This repository has been archived by the owner on Jan 3, 2023. It is now read-only.

Update dependencies via glide update --strip-vendor #69

Merged
merged 1 commit into from
Nov 17, 2017

Conversation

G-Harmon
Copy link
Contributor

@G-Harmon G-Harmon commented Nov 16, 2017

I also had to clear my glide cache (~/.glide/cache) because I hit
Masterminds/glide#592 .

Do this to pick up Nikhil's change in ingress-gce to stop showing testing flags in kubemci -h
(kubernetes/ingress-gce#69)

Testing: Since this picks up a fair amount of new ingress-gce/ code (like NEGs
support), I ran demo.sh and saw that the ingress works.


This change is Reviewable

I also had to clear my glide cache (~/.glide/cache) because I hit
Masterminds/glide#592 .

Do this to pick up Nikhil's change in ingress-gce to stop showing testing flags in kubemci -h
(kubernetes/ingress-gce#69)

Testing: Since this picks up a fair amount of new ingress-gce/ code (like NEGs
support), I ran demo.sh and saw that the ingress works.
@k8s-ci-robot
Copy link

Hi @G-Harmon. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@G-Harmon
Copy link
Contributor Author

@nikhiljindal
Copy link
Contributor

/ok-to-test

@nikhiljindal
Copy link
Contributor

Thx, lgtm. I am surprised this reduces our line count.

/lgtm

@nikhiljindal nikhiljindal merged commit fde111d into GoogleCloudPlatform:master Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants