Add retry tests for Deadline_Exceeded and Unavailable response codes

GoogleCloudPlatform · Jun 12, 2023 · 8a04d55 · 8a04d55
1 parent b1b89dd
commit 8a04d55
Show file tree

Hide file tree

Showing 6 changed files with 1,470 additions and 1 deletion.
diff --git a/exporter/collector/integrationtest/metrics_test.go b/exporter/collector/integrationtest/metrics_test.go
@@ -63,6 +63,12 @@ func TestCollectorMetrics(t *testing.T) {
 			}
 			require.NoError(t, testServerExporter.Shutdown(ctx))
 
+			if !test.ExpectRetries {
+				require.Zero(t, testServer.RetryCount, "Server returned >0 retries when not expected")
+			} else {
+				require.NotZero(t, testServer.RetryCount, "Server returned 0 retries when expected >0")
+			}
+
 			expectFixture := test.LoadMetricFixture(
 				t,
 				test.ExpectFixturePath,

diff --git a/exporter/collector/integrationtest/testcases/testcase.go b/exporter/collector/integrationtest/testcases/testcase.go
@@ -78,6 +78,8 @@ type TestCase struct {
 	SkipForSDK bool
 	// ExpectErr sets whether the test is expected to fail
 	ExpectErr bool
+	// ExpectRetries sets whether the test expects the server to report multiple attempts
+	ExpectRetries bool
 }
 
 func (tc *TestCase) LoadOTLPTracesInput(

diff --git a/exporter/collector/integrationtest/testcases/testcases_metrics.go b/exporter/collector/integrationtest/testcases/testcases_metrics.go
@@ -252,5 +252,29 @@ var MetricsTestCases = []TestCase{
 		},
 		SkipForSDK: true,
 	},
+	{
+		Name:                 "Write ahead log enabled, basic Counter with unavailable return code",
+		OTLPInputFixturePath: "testdata/fixtures/metrics/basic_counter_metrics.json",
+		ExpectFixturePath:    "testdata/fixtures/metrics/basic_counter_metrics_wal_unavailable_expect.json",
+		ConfigureCollector: func(cfg *collector.Config) {
+			cfg.ProjectID = "unavailableproject"
+			cfg.MetricConfig.WALConfig.Enabled = true
+			cfg.MetricConfig.WALConfig.Directory, _ = os.MkdirTemp("", "test-wal-")
+		},
+		SkipForSDK:    true,
+		ExpectRetries: true,
+	},
+	{
+		Name:                 "Write ahead log enabled, basic Counter with deadline_exceeded return code",
+		OTLPInputFixturePath: "testdata/fixtures/metrics/basic_counter_metrics.json",
+		ExpectFixturePath:    "testdata/fixtures/metrics/basic_counter_metrics_wal_deadline_expect.json",
+		ConfigureCollector: func(cfg *collector.Config) {
+			cfg.ProjectID = "deadline_exceededproject"
+			cfg.MetricConfig.WALConfig.Enabled = true
+			cfg.MetricConfig.WALConfig.Directory, _ = os.MkdirTemp("", "test-wal-")
+		},
+		SkipForSDK:    true,
+		ExpectRetries: true,
+	},
 	// TODO: Add integration tests for workload.googleapis.com metrics from the ops agent
 }