Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update new-distro.md #1475

Merged
merged 5 commits into from
Oct 26, 2023
Merged

Update new-distro.md #1475

merged 5 commits into from
Oct 26, 2023

Conversation

sophieyfang
Copy link
Contributor

@sophieyfang sophieyfang commented Oct 23, 2023 •
edited
Loading

Description

Update new-distro.md

Related issue

How has this been tested?

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

martijnvans
martijnvans reviewed Oct 24, 2023
View reviewed changes
dev-docs/new-distro.md Outdated Show resolved Hide resolved
martijnvans
martijnvans requested changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@martijnvans martijnvans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, see my comment about DOCKER_BUILDKIT=1 above

@sophieyfang sophieyfang merged commit e8ffa3f into master Oct 26, 2023
9 checks passed
@sophieyfang sophieyfang deleted the sophieyfang-patch-1 branch October 26, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martijnvans martijnvans martijnvans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sophieyfang @martijnvans