Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SLES bison dependencies. #1479

Merged
merged 3 commits into from
Oct 24, 2023
Merged

Fix SLES bison dependencies. #1479

merged 3 commits into from
Oct 24, 2023

Conversation

igorpeshansky
Copy link
Member

@igorpeshansky igorpeshansky commented Oct 24, 2023 •
edited
Loading

Description

The current SLES 12 build is broken due to a bad bison version, because, apparently, zypper can no longer install the required repo via a URL. This fixes the issue by pulling the repo via docker.

Also, our build only requires bison>3, so fix the broken constraint exposed by #1478.

Related issue

b/307553822

How has this been tested?

Automatic tests should suffice.

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@igorpeshansky
Fix SLES 12 bison repo.
a4b5cad
@igorpeshansky
Fix SLES 12 bison repo in the Dockerfile template.
4438d76 
Sadly, golang/go#45472 has been withdrawn,
so we can't have nicely indented strings.
@igorpeshansky igorpeshansky requested review from a team, hsmatulisgoogle and franciscovalentecastro and removed request for a team and hsmatulisgoogle October 24, 2023 23:04
@igorpeshansky igorpeshansky changed the title Fix SLES 12 bison repo. Fix SLES bison dependencies. Oct 24, 2023
@igorpeshansky igorpeshansky merged commit 84d941c into master Oct 24, 2023
9 checks passed
@igorpeshansky igorpeshansky deleted the igorpeshansky-sles12-bison branch October 24, 2023 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quentinmit quentinmit quentinmit approved these changes

@franciscovalentecastro franciscovalentecastro Awaiting requested review from franciscovalentecastro franciscovalentecastro was automatically assigned from GoogleCloudPlatform/stackdriver-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@igorpeshansky @quentinmit