Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding windows 2025 I think #1845

Merged
merged 3 commits into from
Dec 17, 2024
Merged

adding windows 2025 I think #1845

merged 3 commits into from
Dec 17, 2024

Conversation

braydonk
Copy link
Contributor

Description

This PR adds the Windows 2025 images now available in GCP to project.yaml.

Related issue

b/384012234

How has this been tested?

GitHub Actions 😃

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

project.yaml Outdated Show resolved Hide resolved
@braydonk
Copy link
Contributor Author

Pretty sure the Windows failure in the latest commit is a flake, because for the same image in the commit right before all the tests passed.

@braydonk braydonk merged commit feb99ac into master Dec 17, 2024
66 of 69 checks passed
@braydonk braydonk deleted the braydonk-windows-2025 branch December 17, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants