test: require logger for Ruby ActiveRecord #2770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many existing Ruby ActiveRecord applications have been broken by rails/rails#54260. This also includes the tests and samples for PGAdapter. This workaround makes sure that Logger is required before running the test/sample.
olavloite
force-pushed
the
ruby-active-record-require-logger
branch
from
073a68b to
9be31f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many existing Ruby ActiveRecord applications have been broken by rails/rails#54260. This also includes the tests and samples for PGAdapter. This workaround makes sure that Logger is required before running the test/sample.
Fixes #2763