Implement a custom format parser #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
douglasjacobsen
force-pushed
the
custom_formatter
branch
3 times, most recently
from
026c18e to
cd82c13
Compare
douglasjacobsen
force-pushed
the
custom_formatter
branch
2 times, most recently
from
c7ac48e to
8cd6005
Compare
rfbgo
previously approved these changes
Oct 5, 2023
This commit is a major change to ramble's expander logic. Previously, we relied heavily on Python's f-string format syntax. This causes issues related to formatting template files (like json and yaml), and prevents some usecases (such as in-line variable definitions). This change adds a custom parser for processing strings while they are being expanded.
douglasjacobsen
force-pushed
the
custom_formatter
branch
from
616fe2c to
7db616b
Compare
rfbgo
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge is a major change to ramble's expander logic. Previously, we relied heavily on Python's f-string format syntax. This causes issues related to formatting template files (like json and yaml), and prevents some usecases (such as in-line variable definitions).
This change adds a custom parser for processing strings while they are being expanded.