Add a custom logger to ramble #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
douglasjacobsen
force-pushed
the
custom_logger
branch
5 times, most recently
from
27b94e5 to
27b37f0
Compare
dapomeroy
requested changes
Oct 25, 2023
rfbgo
previously requested changes
Oct 25, 2023
This commit implements a custom logging wrapper (util/logger.py) for ramble which wraps the llnl.util.tty behavior. This primarily allows writing to multiple files with a single call, but fixes some of our issues with the previous logger (namely hijacking stdin).
douglasjacobsen
force-pushed
the
custom_logger
branch
from
66c171b to
e362e31
Compare
dapomeroy
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge adds a custom logger to Ramble to handle the redirection of output to various log files.
It enables a hierarchy of log files, and messages can be printed to multiple of these in a single call. Additionally, it adds progress bars back into Ramble, and adds arguments to disable both the logger, and the progress bars.