Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nested compiler install #302

Conversation

douglasjacobsen
Copy link
Collaborator

This merge fixes compiler installation. Previously, if a compiler needed to be installed, and was required to be installed with a different specific compiler the installation specs were incorrect.

This merge extracts and installs all compilers, including the compilers they are dependent on.

@douglasjacobsen douglasjacobsen added the bug Something isn't working label Oct 26, 2023
@douglasjacobsen douglasjacobsen requested a review from rfbgo October 26, 2023 20:20
rfbgo
rfbgo previously approved these changes Nov 7, 2023
Copy link
Collaborator

@rfbgo rfbgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change, and need to fix conflicts

lib/ramble/ramble/application_types/spack.py Outdated Show resolved Hide resolved
This commit fixes compiler installation. Previously, if a compiler
needed to be installed, and was required to be installed with a
different specific compiler the installation specs were incorrect.

This commit extracts and installs all compilers, including the compilers
they are dependent on.
@rfbgo rfbgo merged commit 99eaa11 into GoogleCloudPlatform:develop Nov 7, 2023
5 checks passed
@douglasjacobsen douglasjacobsen deleted the fix_nested_compiler_install branch November 7, 2023 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants