Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in var/ #344

Merged
merged 2 commits into from
Dec 8, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/spelling.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,5 @@ jobs:
- name: Check Spelling
uses: crate-ci/typos@7ad296c72fa8265059cc03d1eda562fbdfcd6df2 # v1.9.0
szepeviktor marked this conversation as resolved.
Show resolved Hide resolved
with:
files: ./lib/ramble/ramble ./lib/ramble/docs ./examples ./share ./bin ./etc ./README.md
files: ./lib/ramble/ramble ./lib/ramble/docs ./examples ./share ./bin ./etc ./var ./README.md
config: ./.typos.toml
3 changes: 2 additions & 1 deletion .typos.toml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ extend-exclude = [
"lib/ramble/external/",
"lib/ramble/llnl/",
"lib/ramble/spack/",
"var/",
]
ignore-hidden = false

Expand All @@ -17,8 +16,10 @@ extend-ignore-re = [
[default.extend-words]
"fom" = "fom"
"namd" = "namd"
"reord" = "reord"

[default.extend-identifiers]
"ATPase" = "ATPase"
"cachable" = "cachable"
"clen" = "clen"
"enable_deck_based_FOMs" = "enable_deck_based_FOMs"
2 changes: 1 addition & 1 deletion var/ramble/repos/builtin/applications/hmmer/application.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ class Hmmer(SpackApplication):

software_spec('hmmer', spack_spec='[email protected]', compiler='gcc9')

# This would ideally not use the current_relase, as the package will need to be manually updated per release
# This would ideally not use the current_release, as the package will need to be manually updated per release
# Here current_release == 'Pfam36.0'
input_file('Pfam_A',
url='http://ftp.ebi.ac.uk/pub/databases/Pfam/current_release/Pfam-A.hmm.gz',
Expand Down
2 changes: 1 addition & 1 deletion var/ramble/repos/builtin/applications/hpl/application.py
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ class Hpl(SpackApplication):
description='DEPTH for optimized calculator',
workloads=['calculator'])

# FoMs:
# FOMs:
log_str = os.path.join(Expander.expansion_str('experiment_run_dir'),
Expander.expansion_str('experiment_name') + '.out')

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ class IntelHpl(SpackApplication):
description='DEPTH for optimized calculator',
workloads=['calculator'])

# FoMs:
# FOMs:
log_str = os.path.join(Expander.expansion_str('experiment_run_dir'),
Expander.expansion_str('experiment_name') + '.out')

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
from ramble.appkit import *
from ramble.expander import Expander

# Genral Guidance:
# General Guidance:
# - Use compact placement policy
# - Check the compute nodes in a single rack using the network topology API

Expand Down Expand Up @@ -73,7 +73,7 @@ class IntelMpiBenchmarks(SpackApplication):

# Multiple spack packages (specifically intel-oneapi-mpi) provide the
# binary we need. It's fairly common to want to decouple the version of MPI
# from the version of the benchmark, so this varialbe gives a user an
# from the version of the benchmark, so this variable gives a user an
# explicit way to control that, as well as more strongly implies the binary
# from intel-mpi-benchmarks by default
workload_variable('install_path',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ class MdTest(SpackApplication):
software_spec('openmpi', spack_spec='openmpi')

# The IOR spack package also includes MDTest, but we implement it as a
# seperate application in ramble
# separate application in ramble
software_spec('ior', spack_spec='ior', compiler='gcc')

required_package('ior')
Expand Down
2 changes: 1 addition & 1 deletion var/ramble/repos/builtin/applications/namd/application.py
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ class Namd(SpackApplication):
figure_of_merit_context(
'Energy iteration',
regex=energy_regex,
output_format='Enery Iteration: {itr}'
output_format='Energy Iteration: {itr}'
)

figure_of_merit(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ class OsuMicroBenchmarks(SpackApplication):
size_time_regex = r'(?P<msg_size>[0-9.]+)+\s+(?P<fom>[0-9.]+)'
figure_of_merit_context('msg_size',
regex=size_time_regex,
output_format='Messae Size: {msg_size}')
output_format='Message Size: {msg_size}')

log_str = Expander.expansion_str('log_file')
for benchmark, unit in pt2pt:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
class GcpMetadata(BasicModifier):
"""Define a modifier to grab GCP VM metadata

This mod can capture usefull metadata (such as node type and VM image) for
This mod can capture useful metadata (such as node type and VM image) for
GCP VMs
"""

Expand Down