Allow for empty spack env #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
douglasjacobsen
previously approved these changes
Dec 18, 2023
This reverts commit 3753f63.
rfbgo
force-pushed
the
empty_env
branch
2 times, most recently
from
afc0df1 to
7f48227
Compare
This is a little controversial, as it is not super obvious what a dry-run means in the context of analyze, but is required in order for us to both: 1) Analzye non-setup workspaces (such as those that have results but you no longer have the soft env); and 2) Reasonably unit-test software without significant setup The semantic is close to "reduced errors" where by you can continue if a workspace is not setup, and perhaps missing files that setup would normally be required to produce
douglasjacobsen
approved these changes
Jan 19, 2024
linsword13
added a commit
to linsword13/ramble
that referenced
this pull request
Aug 2, 2024
Currently under `workspace` cmd, there are three subcommands that support `--dry-run`: * `setup`: WAI * `mirror`: the dry-run is used by the `software_create_env` and the `mirror_software` stages (spack support only). Updated the help text to make it clearer * `analyze`: the dry-run is used to proceed on partially setup workspace (GoogleCloudPlatform#349.) The usefulness on having this for analyze is debatable, but keeping it for now. Only update the help text for better clarity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow on from #336 which I think did not do what was intended
I want to be able to support something like:
This gives a
len(self.env_contents) == 0so is currently considered invalid.This PR instead lets it continue and hash an empty dict