Fix HPL preventing variable overrides from workspace config #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an issue where variables defined in `ramble.yaml` would not propagate into the HPL.dat. As an example, `"variables:swapping_threshold:999"` would not show up in the generated HPL.dat file when the calculator workload was used. After this chage, these settings propagate correctly. Additionally, some logic around defining HPL settings is cleaned up to make it easier to maintain in the future.
douglasjacobsen
added
bug
rfbgo
approved these changes
Dec 12, 2024
|
Confirmed this addresses the issue |
samskillman
approved these changes
Dec 12, 2024
douglasjacobsen
merged commit 61930c3
into
GoogleCloudPlatform:develop
12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge fixes an issue where variables defined in
ramble.yamlwould not propagate into the HPL.dat.As an example,
"variables:swapping_threshold:999"would not show up in the generated HPL.dat file when the calculator workload was used. After this chage, these settings propagate correctly.Additionally, some logic around defining HPL settings is cleaned up to make it easier to maintain in the future.