Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert https://github.com/GoogleCloudPlatform/ramble/pull/630 #813

Merged
merged 1 commit into from
Jan 8, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 0 additions & 19 deletions lib/ramble/ramble/application.py
Original file line number Diff line number Diff line change
Expand Up @@ -846,25 +846,6 @@ def validate_experiment(self):
# Validate the new modifiers variables exist
# (note: the base ramble variables are checked earlier too)
self.keywords.check_required_keys(self.variables)
self._validate_objects()

def _validate_objects(self):
required_self_attrs = ["name"]

def is_attr_self_defined(obj, attr):
# Use the low level __dict__ to exclude inherited class attrs
return attr in obj.__class__.__dict__

objs = [self, *self._modifier_instances]
if self.package_manager is not None:
objs.append(self.package_manager)
for req_attr in required_self_attrs:
for obj in objs:
if not is_attr_self_defined(obj, req_attr):
raise ApplicationError(
f"Object class {obj.__class__.__name__} is missing "
f"required attribute '{req_attr}'"
)

def _define_custom_executables(self):
# Define custom executables
Expand Down
58 changes: 0 additions & 58 deletions lib/ramble/ramble/test/end_to_end/required_attributes.py

This file was deleted.

This file was deleted.

Loading