Fix relative log paths in FOM and success criteria definitions #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a test (that fails) to ensure log files in figures of merit and success criteria that are not absolute are fixed to contain the full path.
This commit ensures that all log file paths in FOM and Success Criteria are absolute paths instead of allowing relative paths.
rfbgo
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge fixes an issue where FOM and success criteria definitions could refer to log files that were relative to the invocation location of Ramble. This causes them to never be able to extract the correct data. This merge changes this to inject the experiment run directory as a prefix if the log file is not given as an absolute path.
Testing is also added for this.