Workflow tweaks #825
Merged
Workflow tweaks #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
douglasjacobsen
approved these changes
Jan 16, 2025
douglasjacobsen
merged commit 2a2c9c6
into
GoogleCloudPlatform:develop
12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of tweaks based on Doug's feedback:
Add a workload_variable for partition. The subtlety is that now the expansion won't throw error when partition is not explicitly given. So conditionally add in the
-pheader.Ensure
extra_sbatch_headersdoes not get wiped out when one of the entries causes expansion error.