Label all spinnaker services and deployments. #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When new service components (e.g Fiat) were enabled they were not being labeled by `deploy_application_manifest.sh`. This commit resolves the issue by additionally querying the set of deployments and services in the spinnaker namespace and then applying the `app.kubernetes.io/name` with the Spinnaker instance name. Fixes GoogleCloudPlatform#248
stewartmiles
force-pushed
the
fix_labeling_all_services
branch
from
f6c10af to
fcf5140
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When new service components (e.g Fiat) were enabled they were not
being label by
deploy_application_manifest.sh. This commit resolvesthe issue by querying the set of deployments and services in the
spinnaker namespace and then applying the
app.kubernetes.io/namewith the Spinnaker instance name.
Fixes #248