feat: Enable Prometheus sidecar in Cloud Run v2. #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjy9206
requested review from
prabhu34,
anamer,
gtsorbo,
q2w and
a team
as code owners
tjy9206
changed the title
q2w
reviewed
Oct 29, 2024
bharathkkb
approved these changes
Nov 4, 2024
examples/v2_with_gmp/main.tf
Outdated
| */ | ||
|
|
||
| module "cloud_run_v2" { | ||
| source = "tjy9206/cloud-run/google//modules/v2" |
There was a problem hiding this comment.
Thanks for the catch! Added a comment in the ticket as a reminder.
Should I wait this PR to be merged, create a version tag, and create a new PR to refer to that version? Or is there a recommended workflow for version controls like this?
Co-authored-by: Bharath KKB <[email protected]>
…llowup PR to fix it
q2w
reviewed
Nov 7, 2024
There was a problem hiding this comment.
Can we also update https://github.com/GoogleCloudPlatform/terraform-google-cloud-run/blob/main/test/setup/main.tf#L29 to add monitoring.googleapis.com. This API needs to be enabled as per https://cloud.google.com/stackdriver/docs/managed-prometheus/cloudrun-sidecar#enable-apis
q2w
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable Prometheus sidecar in Cloud Run v2. With the sidecar service we can view metrics for Cloud Run instances. Example:
