-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
impl: add a retry with result function (#2837) #2853
impl: add a retry with result function (#2837) #2853
Conversation
* impl: add a retry with result function * fix ci errs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, the codes look good. Would you mind adding some more tests for examining the expected behaviour?
Added unit tests. I ran |
Left one nit comment, once that is resolved we should be able to merge this 🎊 |
Done! Thanks for the reviews 👍 |
Second part of the attempt to fix #1717
Description
Adds a retry loop for the remote image download
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
I'm not sure the best way to test the changes. Any suggestions?
Reviewer Notes
Release Notes
--image-download-retry
to retry when downloading an image