e2e: Use Semantic.DeepEqual to test empty status #1593
Conversation
karlkfi
commented
Mar 7, 2025
karlkfi
commented
- reflect.DeepEqual worked, but Semantic.DeepEqual is preferred for Kubernetes resources.
- Error with the YAML diff if the status is still set
| if len(rg.Status.ResourceStatuses) == 0 { | ||
| return fmt.Errorf("found empty status in %s", core.IDOf(obj)) | ||
| emptyStatus := resourcegroupv1alpha1.ResourceGroupStatus{} | ||
| if equality.Semantic.DeepEqual(emptyStatus, rg.Status) { |
There was a problem hiding this comment.
This seems like a weak assertion - can the test use testpredicates.ResourceGroupStatusEquals instead?
There was a problem hiding this comment.
Yes, but the output isn't consistent yet until after some other PRs merge.
There was a problem hiding this comment.
- fix: ResourceGroup unnecessary timestamp updates #1570 should have fixed the
status.conditionstimestamps continuously updating (b/399892476) - fix: inventory client deleting unmanaged fields #1588 should have fixed the
status.conditionsdisappearing (b/401304237) - fix: ResourceGroup unnecessary condition updates #1571 should have fixed the Reconciling condition flip/flopping (b/399896123)
- fix: ResourceGroup conflicts #1575 should fix
status.observedGenerationbeing updated exclusively by the RGC (b/390467537) - TODO: fix
status.resourceStatuses[*].conditionsdisappearing (b/401315927) - TODO: fix
status.resourceStatuses[*].statusbeing set to UNKNOWN by the applier (b/401315927)
My preference would just be to keep this weak assertion for now, until all the above fixes have landed, especially because the last two might not get fixed until after we land the inventory client rewrite.
- reflect.DeepEqual worked, but Semantic.DeepEqual is preferred for Kubernetes resources.
karlkfi
force-pushed
the
karl-deepequal-status-disabled
branch
from
841fd21 to
99d010e
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sdowell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
bot
merged commit 2595d24
into
GoogleContainerTools:main
