Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: split helm render flags from helm deployer flags #9208

Closed
wants to merge 3 commits into from

Conversation

renzodavid9
Copy link
Contributor

Checking integration tests

Fixes: #nnn
Related: Relevant tracking issues, for context
Merge before/after: Dependent or prerequisite PRs

Description

User facing changes (remove if N/A)

Follow-up Work (remove if N/A)

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Attention: Patch coverage is 87.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 63.67%. Comparing base (290280e) to head (5718404).
Report is 1234 commits behind head on main.

Files with missing lines Patch % Lines
pkg/skaffold/render/renderer/helm/helm.go 80.00% 1 Missing and 1 partial ⚠️
pkg/skaffold/runner/deployer.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9208      +/-   ##
==========================================
- Coverage   70.48%   63.67%   -6.82%     
==========================================
  Files         515      632     +117     
  Lines       23150    32552    +9402     
==========================================
+ Hits        16317    20726    +4409     
- Misses       5776    10235    +4459     
- Partials     1057     1591     +534     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renzodavid9 renzodavid9 added the kokoro:force-run forces a kokoro re-run on a PR label Dec 5, 2023
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants