Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: one last PR of dependency upgrades before the release is cut #9680

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

plumpy
Copy link
Collaborator

@plumpy plumpy commented Jan 23, 2025

No description provided.

Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @plumpy, reviewers, and future viewers!

I'm Gemini, currently reviewing this pull request. In the meantime, I'm providing a summary for everyone to quickly grasp the changes and intent.

This PR, titled chore: one last PR of dependency upgrades before the release is cut, focuses on updating several dependencies before a release. I didn't find a description, so this summary is based solely on the code changes.

Here's a breakdown of the modifications:

  • Dependency Upgrades: The pull request updates various dependencies to their latest versions:

    • kubectl: Updated from v1.32.0 to v1.32.1 (line 21 of deploy/skaffold/Dockerfile.deps)
    • helm: Updated from v3.16.4 to v3.17.0 (line 31 of deploy/skaffold/Dockerfile.deps)
    • kustomize: Updated from 5.5.0 to 5.6.0 (line 40 of deploy/skaffold/Dockerfile.deps)
    • k3d: Updated from v5.7.5 to v5.8.1 (line 85 of deploy/skaffold/Dockerfile.deps)
    • gcloud: Updated from 505.0.0 to 507.0.0 (line 94 of deploy/skaffold/Dockerfile.deps)
    • bazel: Updated from 8.0.0 to 8.0.1 (line 107 of deploy/skaffold/Dockerfile.deps)
    • docker: Updated from 23.0.1 to 27.5.1 (line 123 of deploy/skaffold/Dockerfile.deps)
    • docker/buildx-bin: Updated from 0.10.4 to 0.20.1 (line 125 of deploy/skaffold/Dockerfile.deps)
    • golang: Updated from 1.23.4 to 1.23.5 (line 165 of deploy/skaffold/Dockerfile.deps)
    • Several other indirect dependencies were also updated in go.mod and go.sum.
  • Digest Updates: SHA256 digests for all updated dependencies have been updated to reflect the new versions in the deploy/skaffold/digests directory.

  • Copyright Year Update: Copyright years in several vendor files have been updated to 2025 (various files in the vendor directory).

  • Monitoring API Change: A new active_only field was added to the ListMetricDescriptorsRequest in vendor/cloud.google.com/go/monitoring/apiv3/v2/monitoringpb/metric_service.pb.go (line 324).

I'll be providing a more detailed review shortly. Until then, happy reviewing!

Small changes made,
Code now feels new,
Release is closer.

Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request updates several dependencies, which is good practice for maintaining a healthy codebase. I've checked the updated versions and they appear to be the latest stable releases. Ensuring the digests are updated is crucial for security and reproducibility. A few minor suggestions below.

@plumpy plumpy force-pushed the hit_me_baby_one_more_time branch from 6a0687d to 41a5f4a Compare January 23, 2025 13:47
@plumpy plumpy marked this pull request as ready for review January 23, 2025 14:26
@plumpy plumpy requested a review from a team as a code owner January 23, 2025 14:26
@plumpy plumpy requested review from katiexzhang and mattsanta and removed request for katiexzhang January 23, 2025 14:26
@mattsanta mattsanta merged commit b6acfa8 into GoogleContainerTools:main Jan 23, 2025
13 checks passed
@plumpy plumpy deleted the hit_me_baby_one_more_time branch January 23, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants