Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up actions names #263

Merged
merged 4 commits into from
Jun 9, 2021
Merged

Tidy up actions names #263

merged 4 commits into from
Jun 9, 2021

Conversation

dbr
Copy link
Collaborator

@dbr dbr commented Jun 5, 2021

No description provided.

@dbr dbr self-assigned this Jun 5, 2021
@dbr dbr linked an issue Jun 5, 2021 that may be closed by this pull request
@dbr dbr changed the title First pass at tidying action names Tidy up actions names Jun 5, 2021
@dbr dbr marked this pull request as ready for review June 5, 2021 04:03
@dbr dbr requested a review from djmitche as a code owner June 5, 2021 04:03
@dbr
Copy link
Collaborator Author

dbr commented Jun 5, 2021

So I think this is about as good as I can get it. Only main weirdness is the "Clippy Results" thing which produces the inline-annotations (from https://github.com/actions-rs/clippy-check ) seems to appear under a random section and there's no obvious way to control this

@dbr
Copy link
Collaborator Author

dbr commented Jun 5, 2021

Ah the weirdness is a known bug, actions-rs/clippy-check#45

Copy link
Collaborator

@djmitche djmitche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Maybe we can also remove "Test - " from the test actions? This is also fine by me as-it-is.

@djmitche
Copy link
Collaborator

djmitche commented Jun 8, 2021

Did you want to merge this?

@dbr dbr merged commit 5c7d933 into main Jun 9, 2021
@dbr dbr deleted the actionnames branch June 9, 2021 01:38
@dbr
Copy link
Collaborator Author

dbr commented Jun 9, 2021

Woops, yep! Thanks for the reminder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix names of actions
2 participants