Fix tests #7
Fix tests #7
Conversation
Also fixes GovReady#3. Checks whether the next nonspace is None which means that it is a blank line. Alters the test case to fit in with the Google Flavoured Markdown (GFM) spec.
Removes extraneous cells if more columns than header row.
This makes a few changes - The `table` function in `BlockStarts` returns 2 now - Returning 2 now sets `matched_leaf = True` in `commonmark`, which a table is a leaf node in markdown - I found this meant that it didn't slurp up the whitespace on the first line, yet still passed all the tests. - Add the pipe symbol back to the start of each line after slurping in `node.string_content` - In the `finalize` function, ignore the first pipe on the line (keeping the same functionality of before when it got slurped) - Also in `finalize`, if a mix-match between the delimiter row and the header row is found, set the node type to `paragraph` N.B. This doesn't change the underlying python object type, just sets `block.t = 'paragraph` which appears to work on rendering
| @@ -141,6 +143,7 @@ def test_break2(self): | |||
| </tr> | |||
| </tbody> | |||
| </table> | |||
|
|
|||
There was a problem hiding this comment.
This differs slightly from the spec, but doesn't actually change the visual output of the html (as blank lines aren't treated specially).
If you are bothered by this, let me know and I can try work out why the new line appears and whether we can avoid it.
| @@ -107,6 +117,9 @@ def finalize(parser=None, block=None): | |||
| if len(list(filter(lambda cell : not re.match(r"[-=:]+$", cell), row))) == 0: | |||
| # This row has cells of just dahses. | |||
| if len(table_parts) == 1: | |||
| if len(row) != len(table_parts[0][0]): | |||
| block.t = 'paragraph' | |||
There was a problem hiding this comment.
As mentioned in commit message, this doesn't actually change the Python type of the block, but it does produce the right output on rendering so likely doesn't matter.
| @@ -25,7 +25,8 @@ def table(parser, container): | |||
| parser.advance_offset(1, False) | |||
| parser.close_unmatched_blocks() | |||
| parser.add_child('table', parser.next_nonspace) | |||
| return 1 | |||
| parser.tip.string_content = '|' | |||
| return 2 | |||
There was a problem hiding this comment.
Returning 2 makes it a leaf node, which in practice means that it doesn't slurp up whitespace after the |, meaning the pipe can be added back simply.
|
Fixes #2 |
|
My latest PR (#11) may have broken this. Have not tested |
Fixes #6.
Also fixes #3.